ELSE expressions terminate early when encountering an END token#654
Open
SharpDerek wants to merge 1 commit intophpmyadmin:masterfrom
Open
ELSE expressions terminate early when encountering an END token#654SharpDerek wants to merge 1 commit intophpmyadmin:masterfrom
SharpDerek wants to merge 1 commit intophpmyadmin:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
=========================================
Coverage 96.30% 96.30%
- Complexity 2254 2255 +1
=========================================
Files 90 90
Lines 4982 4982
=========================================
Hits 4798 4798
Misses 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
williamdes
approved these changes
Apr 25, 2026
Member
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
Thank you for this fix. If possible please reset your branch to 5.11.x and cherry pick your work and force push.
It will allow us to have the fix on 5.11.x
Else just let me know and I will do it manually
Member
|
Also, please add test cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CASE statements with an ELSE returning a value with the "tablename.columnname" format fail due to encountering an END token and parsing it as if it were a column instead. This fixes the issue by checking to see if the current token is an END and breaks before column processing.